Repository navigation
Fix struct name collision caused by upstream PostgreSQL change - #437
Merged
Merged
Conversation
It is not recommended for production. Released versions at the moment are from REL1_6_STABLE (relatively modern, Java 9+, PostgreSQL 9.5+) or from REL1_5_STABLE (if support for Java < 9 or PostgreSQL < 9.5 is needed).
String is a PostgreSQL type, rename pljava String to PLJString
Addresses #410. In postgres/postgres@639a86e, the 'Value' Node struct was retired, and Integer, Float, String, and BitString became Node structs in their own right; the name String collides with the one in PL/Java's String.c. An easy solution is to change the name of the latter. Tested by Christoph Berg, tayalrun1, Frank Blanning, aadrian, Yuril Rashkovskii. The upstream change made changes in nodeToString in outfuncs.c, but only as needed to preserve the original pg_node_tree syntax, so no attention to PgNodeTreeAsXML is needed. (It would be good for that to have a regression test, on general principles.)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #410. In postgres/postgres@639a86e, the
Valueflavor ofNodestruct was retired, andInteger,Float,String, andBitStringbecameNodestructs in their own right; the nameStringcollides with the one in PL/Java'sString.c. An easy solution is to change the name of the latter.Thanks to Francisco Miguel Biete Banon; tested by Christoph Berg, tayalrun1, Frank Blanning, aadrian, Yuril Rashkovskii.
The upstream change made changes in
nodeToStringinoutfuncs.c, but only as needed to preserve the originalpg_node_treesyntax, so no attention toPgNodeTreeAsXMLis needed. (It would be good for that to have a regression test, on general principles.)