Repository navigation
#6/7/12 samples: error checking and logging capability - #9
Merged
Merged
Conversation
| import argparse | ||
|
|
||
| # import logging | ||
| # logging.basicConfig(level=logging.DEBUG) |
Contributor
There was a problem hiding this comment.
It might be nice to allow people to set the logging level from the command line
Contributor
|
🚀 |
| raise LookupError(error) | ||
| else: | ||
| print('No workbook named {} found.'.format(args.workbook_name)) | ||
| error = "The default project could not be found." |
Contributor
There was a problem hiding this comment.
It is not the default project which can't be found. it is the destination project which cannot be found
shinchris
changed the title
| parser.add_argument('password', help='password to sign into server') | ||
| parser.add_argument('-info', action='store_true', help='set this flag to show logging information on INFO level') | ||
| parser.add_argument('-debug', action='store_true', help='set this flag to show logging information on DEBUG level') | ||
| parser.add_argument('-publish', '-p', metavar='FILEPATH', help='path to datasource to publish') |
Contributor
There was a problem hiding this comment.
I'm pretty sure you are fixing this in another feature branch, but consistency is good. Long names should always be --, short names (single letters) should be -.
Contributor
|
🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.