Skip to content

Allow wb/ds item or id in refresh #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jorwoods wants to merge 2 commits into from
Closed

Allow wb/ds item or id in refresh #563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bb7a32c
Allow wb/ds item or id in refresh
Feb 6, 2020
8ff7f7b
Permit object or id in Jobs.cancel
Feb 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tableauserverclient/server/endpoint/datasources_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,8 @@ def update_connection(self, datasource_item, connection_item):
return connection

def refresh(self, datasource_item):
url = "{0}/{1}/refresh".format(self.baseurl, datasource_item.id)
id_ = getattr(datasource_item, 'id', datasource_item)
url = "{0}/{1}/refresh".format(self.baseurl, id_)
empty_req = RequestFactory.Empty.empty_req()
server_response = self.post_request(url, empty_req)
new_job = JobItem.from_response(server_response.content, self.parent_srv.namespace)[0]
Expand Down
3 changes: 2 additions & 1 deletion tableauserverclient/server/endpoint/jobs_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@ def get(self, job_id=None, req_options=None):

@api(version='3.1')
def cancel(self, job_id):
url = '{0}/{1}'.format(self.baseurl, job_id)
id_ = getattr(job_id, 'id', job_id)
url = '{0}/{1}'.format(self.baseurl, id_)
return self.put_request(url)

@api(version='2.6')
Expand Down
3 changes: 2 additions & 1 deletion tableauserverclient/server/endpoint/workbooks_endpoint.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ def get_by_id(self, workbook_id):

@api(version="2.8")
def refresh(self, workbook_id):
url = "{0}/{1}/refresh".format(self.baseurl, workbook_id)
id_ = getattr(workbook_id, 'id', workbook_id)
url = "{0}/{1}/refresh".format(self.baseurl, id_)
empty_req = RequestFactory.Empty.empty_req()
server_response = self.post_request(url, empty_req)
new_job = JobItem.from_response(server_response.content, self.parent_srv.namespace)[0]
Expand Down