Repository navigation
Project Permission & Default Permission Docs - #528
Conversation
|
@dzucker-tab look good to you? |
dzucker-tab
left a comment
dzucker-tab
left a comment
There was a problem hiding this comment.
Links all look good. There is a clarifying change I would suggest for the default permissions descriptions, but honestly, no kittens would die (or developers would be confused) if you published what you have.
| projects.populate_workbook_default_permissions(item) | ||
| ``` | ||
|
|
||
| Queries the default workbook permissions, parses and stores the returned the permissions. |
There was a problem hiding this comment.
Take or leave these comments. I think what you have is legible.
-
In descriptive content it is data source not datasource.
-
The name of the method already says this is about default permissions of a project, but the sentence, standalone, would include that context if it were:
Queries the default permissions of workbooks in a project, parses and stores the returned the permissions.
| projects.populate_datasource_default_permissions(item) | ||
| ``` | ||
|
|
||
| Queries the default datasource permissions, parses and stores the returned the permissions. |
There was a problem hiding this comment.
same as comment above, suggest:
Queries the default permissions of data sources in a project, parses and stores the returned the permissions.
| projects.populate_flow_default_permissions(item) | ||
| ``` | ||
|
|
||
| Queries the default flow permissions, parses and stores the returned the permissions. |
There was a problem hiding this comment.
Again:
Queries the default permissions for flows in a project, parses and stores the returned the permissions.
| projects.update_workbook_default_permissions(item, rules) | ||
| ``` | ||
|
|
||
| Add or update default workbook permissions. |
There was a problem hiding this comment.
Again:
Add or update default permissions for workbooks in a project.
| projects.update_datasource_default_permissions(item, rules) | ||
| ``` | ||
|
|
||
| Add or update default datasource permissions. |
There was a problem hiding this comment.
You get the idea:
Add or update default permissions for data sources in a project.
| projects.update_flow_default_permissions(item, rules) | ||
| ``` | ||
|
|
||
| Add or update default flow permissions. |
There was a problem hiding this comment.
yawn . . .
Add or update default permissions for flows in a project.
| projects.delete_workbook_default_permissions(item, rules) | ||
| ``` | ||
|
|
||
| Delete default workbook permissions. |
There was a problem hiding this comment.
mm hm ...
Delete default permissions for workbooks in a project.
| projects.delete_datasource_default_permissions(item, rules) | ||
| ``` | ||
|
|
||
| Delete default datasource permissions. |
There was a problem hiding this comment.
you guessed it:
Delete default permissions for data sources in a project.
| projects.delete_flow_default_permissions(item, rules) | ||
| ``` | ||
|
|
||
| Delete default flow permissions. |
There was a problem hiding this comment.
that's right:
Delete default permissions for flows in a project.
No description provided.