Skip to content

#11 moved requests-mock library dependency to tests_require #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shinchris merged 2 commits into from
Sep 8, 2016
Merged

#11 moved requests-mock library dependency to tests_require #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e1040b
Add automated test runs via travis (#8)
Sep 2, 2016
34595b9
moved request-mock library to tests_require
shinchris Sep 6, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
language: python

@t8y8 t8y8 Sep 7, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this from the PR

python:
- "2.7"
- "3.3"
- "3.4"
- "3.5"
- "pypy"
# command to install dependencies
install:
- "pip install -e ."
# - "pip install pep8"
# command to run tests
script:
# Tests
- python setup.py test
# pep8 - disabled for now until we can scrub the files to make sure we pass before turning it on
# - pep8 .
4 changes: 3 additions & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@
description='A Python module for working with the Tableau Server REST API.',
test_suite='test',
install_requires=[
'requests>=2.11,<2.12.0a0',
'requests>=2.11,<2.12.0a0'

@t8y8 t8y8 Sep 7, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's bad form to pin between a certain version range unless you really need it -- is there a reason for the max version?

Requests API is very stable, >= should be sufficient (And not require us to update this every time requests releases a new version)

],
tests_require=[
'requests-mock>=1.0,<1.1a0'
]
)