Repository navigation
Jac/redact embedded creds - #1035
Merged
Merged
Conversation
Use it to remove passwords from logs with publish requests and responses, which can contain embedded credentials.
skip redaction for python 3.6 b/c it doesn't do single dispatch
vogelsgesang
requested changes
May 11, 2022
add python version enforcement in setup.py
but don't bother redacting the word "password"
Contributor
|
The approach breaks my brain a little -- given that workbooks/datasources have been XML for ~15 years and probably will remain so, I would advocate an approach where we just strip any element or attribute with a tag name or attribute name of 'password', 'secret' etc. It would protect you from parsing xml manually and be easier to troubleshoot in the future I think. Something like |
mwhagedorn
reviewed
May 25, 2022
mwhagedorn
reviewed
May 25, 2022
mwhagedorn
reviewed
May 25, 2022
mwhagedorn
left a comment
mwhagedorn
left a comment
There was a problem hiding this comment.
looks good, couple minor questions, no blockers
I noticed that dqw didn't have any tests, and I hadn't covered the "redact a not-xml string" case
jacalata
added a commit
that referenced
this pull request
Jun 1, 2022
* add redaction method to remove passwords when logging requests and responses, which can contain embedded credentials. * remove support for python 3.6 (add python version enforcement in setup.py)
jacalata
added a commit
that referenced
this pull request
Jun 6, 2022
* add redaction method to remove passwords when logging requests and responses, which can contain embedded credentials. * remove support for python 3.6 (add python version enforcement in setup.py)
jacalata
added a commit
that referenced
this pull request
Sep 20, 2022
* add redaction method to remove passwords when logging requests and responses, which can contain embedded credentials. * remove support for python 3.6 (add python version enforcement in setup.py)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
call a redaction method before logging workbook/ds file contents to overwrite embedded credentials with junk (fixes #1024 for real)
does not work in 3.6