Repository navigation
urllib3 specific version requirement causing dependencies conflict #1445
Description
Describe the bug
I was trying to upgrade the version from 0.25 to fix the filename issue per #1312
However, I am not able to upgrade because the requirement of urllib3==2.2.2 is causing dependencies conflict issue with other packages in my environment. Check the history and it seems starting 0.27 version the requirement became very specific.
Do we really need this specific version? Can we make it to urllib3>=2 or exclude versions we don't want to use?
server-client-python/pyproject.toml
Line 18
in
257cf61
server-client-python/pyproject.toml
Line 18 in 257cf61
Versions
Details of your environment, including:
- Tableau Server version: 3.19
- Python version: 3.9.13
- TSC library version: 0.25 to 0.32
Activity
jacalata commentedon Aug 22, 2024
Hm. We pinned the specific versions of libraries because we had some breaks from minor version updates. I would like to at least pin the minor version - would 2.2.x be loose enough for you? I expect that there will be some noticeable changes through the life of 2.x
thesuperzapper commentedon Sep 10, 2024
@jacalata its extremely bad practice to pin a specific version of a one of the most common python libraries in the world.
The only reason why this doesn't make
tableauserverclientcompletely un-installable is because no other package is crazy enough to specify a specific version.Please use normal constraints like
>X.Y.Z,<3whereX.Y.Zis whatever the minimum required version is.jackexu commentedon Sep 11, 2024
Agreed with @thesuperzapper
If there are versions that have known issue then just exclude them - e.g.
>2, <3, !=X.Y.ZMake urllib3 dependency more flexible
Draft: Make urllib3 dependency more flexible (#1468)
Draft: Make urllib3 dependency more flexible (tableau#1468)