Skip to content

"from_response" should not be on TableauAuth object #1

Closed
Closed
"from_response" should not be on TableauAuth object#1
Milestone
0.1

Description

@LGraber
LGraber
opened on Sep 2, 2016

You must have missed this from an earlier review. "from_response" implies that it is constructing the class object. This code is simply parsing the response of "signin" and is not constructing a TableauAuth object. Please just move this to the "signin" method.

Activity

  1. graysonarts
    modified the milestone: 0.1 on Sep 2, 2016
  2. shinchris
    added a commit that references this issue on Sep 6, 2016

    #1 moved auth parsing to signin method (#5)

    cfa1f55
  3. shinchris
    closed this as completedon Sep 6, 2016
  4. jacalata
    added a commit that references this issue on Oct 6, 2022

    Add permission control for Data Roles and Metrics (Issue #1063) (#1120)

    bad5db9
  5. bryceglarsen
    added a commit that references this issue on Dec 28, 2023

    Merge pull request tableau#1 from mpope-tableau/master

    1ae3195
  6. jacalata
    added a commit that references this issue on Jul 25, 2025

    Merge pull request #1 from jorwoods/jorwoods/conns_req_fact

    8ee48d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions