Skip to content

MANIFEST.in: Add docs and test data - #473

Merged
0golovatyi merged 1 commit into
tableau:masterfrom
jayvdb:sdist
Jan 22, 2021
Merged

0golovatyi merged 1 commit into
tableau:masterfrom
jayvdb:sdist

Conversation

@jayvdb

@jayvdb jayvdb commented Jan 21, 2021 •

Copy link
Copy Markdown
Contributor

Closes #472

@0golovatyi

Copy link
Copy Markdown
Contributor

@jayvdb Could you clarify why and when those additional files needed in the package?

@0golovatyi 0golovatyi closed this Jan 22, 2021
@jayvdb

jayvdb commented Jan 22, 2021

Copy link
Copy Markdown
Contributor Author

@0golovatyi , On #472 you said you were approving it, but here you closed it without merging.

@0golovatyi 0golovatyi reopened this Jan 22, 2021
@0golovatyi
0golovatyi merged commit edd5101 into tableau:master Jan 22, 2021
@0golovatyi

Copy link
Copy Markdown
Contributor

Sorry, my bad. Shouldn't have done it late night... Reopened and merged.

@jayvdb

jayvdb commented Jan 23, 2021

Copy link
Copy Markdown
Contributor Author

Minor note, not urgent, tag 2.3.2 hasnt been pushed to PyPI yet.

@jayvdb

jayvdb commented Jan 26, 2021

Copy link
Copy Markdown
Contributor Author

Still no 2.3.2 on PyPI @0golovatyi

@0golovatyi

Copy link
Copy Markdown
Contributor

@jayvdb There is no differences between 2.3.1 and 2.3.2 as test code is not added to the package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyPI sdist doesnt contain resources

2 participants