Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basic idea is to just pass the 12 byte native representation to JS, allowing for wicked fast small string decoding and "immortal" string caching. Especially for browser use cases, where small ASCII strings are everywhere, this is quite noticeable.
In addition to a tiny bit of added complexity in the glue code, the only real downside is that we add a dependency to Swift's internal String representation, which can of course change with toolchain versions and we'd need to deal with that. I would expect that to be a somewhat infrequent event though.
I know this is a bit wild, but see a few numbers from local benchmarking below - I think it's worth it.
Apple M5 Pro · Node.js 22.21.1 · Local
main(777848df) vs PR implementation. Median milliseconds per 300,000 decodes, across 30 samples. Decoder-only timings; excludes Swift lowering and Wasm calls.abc😄)js-framework-benchmark (in chrome on M5 Pro) with ElementaryUI (current main)
comparing JavaScriptKit 0.59.0 vs this PR
(for reference, shaving off ~10% with other means is getting really, really tough - this is the last big gun I think)
Duration
Memory allocation
Transferred size and first paint