Repository navigation
Bound HTML entity scanning to prevent denial of service - #29
Merged
Merged
Conversation
<!-- coderabbit-ai-generated:v1 -->
Contributor
Author
|
Important Review skippedThis PR was authored by the user configured for CodeRabbit reviews. CodeRabbit does not review PRs authored by this user. It's recommended to use a dedicated user account to post CodeRabbit review feedback.
 |
sudo-py-dev
deleted the
coderabbit/bound-entity-decoding-scan/7a96a420
branch
November 9, 2026 11:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Limit entity terminator searches in src/office.rs to 11 bytes, preventing quadratic scanning of repeated unterminated entities while preserving the 10-byte entity-name limit and UTF-8 safety.
Add regression tests for valid and malformed entities, length boundaries, multibyte text, and HTML containing one million ampersands with varied suffixes.
Validation: Tests were not run.
View coding task