Skip to content

Revert "Limit memory usage for reverse and silence-trimming conversions" - #18

Closed
sudo-py-dev wants to merge 1 commit into
mainfrom
revert-15-coderabbit/bound-audio-reversal-memory/e6edf8eb
Closed

sudo-py-dev wants to merge 1 commit into
mainfrom
revert-15-coderabbit/bound-audio-reversal-memory/e6edf8eb

Conversation

@sudo-py-dev

@sudo-py-dev sudo-py-dev commented Nov 9, 2026 •

Copy link
Copy Markdown
Owner

Reverts #15

Summary by CodeRabbit

  • Behavior Changes
    • Reverse and silence-trimming operations are no longer subject to a fixed memory limit. This may allow some larger files to be processed, but these operations can use more system memory.
    • Progress reporting during media processing remains available.

@coderabbitai

coderabbitai Bot commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

Caution

Review failed

The pull request is closed.

Walkthrough

Process memory limits are removed from process execution and media plans. The run_limited API, platform-specific enforcement, related plan settings, and tests are deleted. FFmpeg now uses the regular process runner.

Changes: Process memory-limit removal

Layer / File(s) Summary
Remove process-level memory enforcement
src/process.rs, src/process_memory.rs, Cargo.toml
The process runner no longer applies OS-enforced memory limits. The platform-specific implementation, its test, and the libc and windows-sys dependencies are removed.
Remove memory-limit settings from media execution
src/plan.rs, src/media_tools.rs, src/ffmpeg.rs, src/exec.rs
Plans and media recipes no longer set memory limits or buffering-tool thread flags. FFmpeg uses process::run. Tests for memory-limit behavior are removed.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Suggested labels: rust

Merge Risk: Low · up to 5fc09

This revert restores the earlier behavior in which reversing a long or high-resolution video has no memory cap. Such a job could exhaust host memory before it is cancelled. Merging is acceptable if the team accepts that tradeoff; otherwise a separate bound on buffered conversions is needed.

- [ ] Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@sudo-py-dev sudo-py-dev closed this Nov 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant