Skip to content

Expose path to the built-in favicon file - #729

Merged
bajtos merged 1 commit into
masterfrom
feature/expose-path-to-default-favicon
Nov 3, 2014
Merged

bajtos merged 1 commit into
masterfrom
feature/expose-path-to-default-favicon

Conversation

@bajtos

@bajtos bajtos commented Nov 3, 2014

Copy link
Copy Markdown
Member

The path is available via loopback.faviconFile.

This change makes it possible to use the serve-favicon middleware directly:

// before
app.use(loopback.favicon());
// now
app.use(require('serve-favicon')(loopback.faviconPath));

/to @ritch @raymondfeng please review

The path is available via `loopback.faviconFile`.
@ritch

ritch commented Nov 3, 2014

Copy link
Copy Markdown
Member

LGTM

bajtos added a commit that referenced this pull request Nov 3, 2014
…t-favicon

Expose path to the built-in favicon file
@bajtos
bajtos merged commit 7798403 into master Nov 3, 2014
@bajtos
bajtos deleted the feature/expose-path-to-default-favicon branch November 3, 2014 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants