Skip to content

Add templateFn option to User.prototype.verify() - #2935

Closed
adrien-k wants to merge 0 commit into
strongloop:masterfrom
adrien-k:master
Closed

adrien-k wants to merge 0 commit into
strongloop:masterfrom
adrien-k:master

Conversation

@adrien-k

Copy link
Copy Markdown
Contributor

Description

Related issues

This would give a bit more flexibility to User.prototype.verify() email rendering and provide a workaround to the following issue:

Checklist

  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style
    guide

@slnode

slnode commented Nov 11, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@adrien-k adrien-k changed the title Add custom templateFn option to User.prototype.verify() Add templateFn option to User.prototype.verify() Nov 11, 2016
@bajtos

bajtos commented Nov 11, 2016

Copy link
Copy Markdown
Member

@slnode ok to test

@bajtos bajtos self-assigned this Nov 11, 2016
@bajtos

bajtos commented Nov 11, 2016

Copy link
Copy Markdown
Member

Hi @adrien-k, thank you for the pull request, I appreciate the work you have put into this patch. I took a quick look. The approach looks reasonable to me, I'll perform a more detailed review next week.

@bajtos bajtos closed this Nov 14, 2016
@slnode

slnode commented Nov 14, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

3 similar comments
@slnode

slnode commented Nov 14, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

@slnode

slnode commented Nov 14, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

@slnode

slnode commented Nov 14, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

@bajtos

bajtos commented Nov 14, 2016

Copy link
Copy Markdown
Member

@adrien-k I was cleaning up the code a bit and accidentally closed your patch. My bad! Let's move the discussion to #2937.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants