Skip to content

Fix context within listByPrincipalType role method - #2742

Merged
bajtos merged 1 commit into
strongloop:masterfrom
codyolsen:feature/role-context
Nov 15, 2016
Merged

bajtos merged 1 commit into
strongloop:masterfrom
codyolsen:feature/role-context

Conversation

@codyolsen

Copy link
Copy Markdown
Contributor
  • Fix for current implimentation that returned all models that had any
    assigned roles. Context was not carried into listByPrincipalType,
    setting roleId as null.

@slnode

slnode commented Sep 13, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@slnode

slnode commented Sep 13, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

3 similar comments
@slnode

slnode commented Sep 13, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

@slnode

slnode commented Sep 13, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

@slnode

slnode commented Sep 13, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

@bajtos

bajtos commented Nov 10, 2016

Copy link
Copy Markdown
Member

@slnode test please

- Fix for current implimentation that returned all models that had any
  assigned roles. Context was not carried into listByPrincipalType,
  setting roleId as null.
@bajtos

bajtos commented Nov 15, 2016

Copy link
Copy Markdown
Member

@slnode ok to test

@bajtos
bajtos merged commit 54ee8d8 into strongloop:master Nov 15, 2016
@bajtos

bajtos commented Nov 15, 2016

Copy link
Copy Markdown
Member

Landed, thank you @codyolsen for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants