Skip to content

Update dependencies to their latest versions - #2577

Merged
jannyHou merged 5 commits into
masterfrom
update-deps
Aug 4, 2016
Merged

jannyHou merged 5 commits into
masterfrom
update-deps

Conversation

@bajtos

@bajtos bajtos commented Aug 2, 2016

Copy link
Copy Markdown
Member

cc @strongloop/loopback-dev FYI, I think no review is needed

@bajtos bajtos self-assigned this Aug 2, 2016
@bajtos bajtos added the #review label Aug 2, 2016
@bajtos

bajtos commented Aug 2, 2016

Copy link
Copy Markdown
Member Author

@slnode test please

1 similar comment
@bajtos

bajtos commented Aug 2, 2016

Copy link
Copy Markdown
Member Author

@slnode test please

bajtos added 2 commits August 3, 2016 16:17
Rework the test suite to always report errors and correctly signal
when async tests are done.

This should prevent spurious test failures on CI servers that are
difficult to troubleshoot, because the error is reported for different
test case.
@jannyHou

jannyHou commented Aug 3, 2016

Copy link
Copy Markdown
Contributor

LGTM 👍

bajtos added 3 commits August 4, 2016 11:00
Rework assertions to report helpful messages on failure.

Increase the "elapsed" limit from 100ms to 300ms to support our
slow CI machines.
Rework the test to always wait for the client request to finish before
calling the test done.
@bajtos

bajtos commented Aug 4, 2016

Copy link
Copy Markdown
Member Author

Yay, loopback itself is green now 💃

@jannyHou I added three more commits, could you please review them?

Other than that, I think this patch is ready for landing.

@bajtos

bajtos commented Aug 4, 2016

Copy link
Copy Markdown
Member Author

@slnode test please

@jannyHou

jannyHou commented Aug 4, 2016

Copy link
Copy Markdown
Contributor

👍 loopback itself are all green. Thank you @bajtos Let's land it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants