Repository navigation
Remove options.template to prevent rejection by certain nodemailer transport plugins - #1831
sharkinsspatial wants to merge 1 commit into
Conversation
Removes options.template after options.html is generated to prevent rejection by certain nodemailer transport plugins.
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
Any update on this? Appears to ready for merge but I haven't seen any motion on it in awhile. |
|
@ritch you are most familiar with this part of code, please review. @sharkinsspatial could you please add a unit-test to verify your fix and prevent regressions in the future? |
@ritch @sharkinsspatial Ping. |
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
@ritch Ping. Do you know if there are any negatives to adding this one line? |
|
Can this pull request be merged by someone? Just ran into this issue again. |
|
Can one of the admins verify this patch? |
3 similar comments
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
Can one of the admins verify this patch? |
|
@bajtos What should we do here? It's been open since May. |
We need somebody to add the unit-test or explain why adding such test is not feasible. If @sharkinsspatial, the author of this patch, does not have the bandwidth, then it would be great if one of the functional-area owners (@loay for loopback-auth, @jannyHou / @davidcheung for connector-email) could step in and take over this work. |
|
Closing in favour of #3004 |
Removes options.template after options.html is generated to prevent
rejection by certain nodemailer transport plugins.