Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions lib/application.js
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,24 @@ app.models = function () {
return this._models || (this._models = []);
}

/**
* Look up a model class by the base model class.
* The method can be used by LoopBack to find models configured in models.json
* over the base model.
* @param {Model} The base model class
* @return {Model} The subclass if found or null
*/
app.getModelByType = function(modelType) {
assert(typeof modelType === 'function', 'modelType must be a constructor');
var models = this.models;
for(var m in models) {
if(models[m].prototype instanceof modelType) {
return models[m];
}
}
return null;
};

/**
* Define a DataSource.
*
Expand Down
14 changes: 14 additions & 0 deletions lib/middleware/rest.js
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ module.exports = rest;
*/

function rest() {
var token = null;
return function (req, res, next) {
var app = req.app;
var handler = app.handler('rest');
Expand All @@ -23,6 +24,19 @@ function rest() {
res.send(handler.adapter.allRoutes());
} else if(req.url === '/models') {
return res.send(app.remotes().toJSON());
} else if (app.isAuthEnabled) {
if (!token) {
token = loopback.token({
model: app.getModelByType(loopback.AccessToken)
});
}

token(req, res, function(err) {
if (err)
next(err);
else
handler(req, res, next);
});
} else {
handler(req, res, next);
}
Expand Down
2 changes: 2 additions & 0 deletions lib/middleware/token.js
Original file line number Diff line number Diff line change
Expand Up @@ -53,12 +53,14 @@ function token(options) {
assert(TokenModel, 'loopback.token() middleware requires a AccessToken model');

return function (req, res, next) {
if (req.accessToken !== undefined) return next();
TokenModel.findForRequest(req, options, function(err, token) {
if(err) return next(err);
if(token) {
req.accessToken = token;
next();
} else {
req.accessToken = null;
return next();
}
});
Expand Down
21 changes: 21 additions & 0 deletions test/access-token.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,27 @@ describe('loopback.token(options)', function() {
.end(done);
});
});

it('should skip when req.token is already present', function(done) {
var tokenStub = { id: 'stub id' };
app.use(function(req, res, next) {
req.accessToken = tokenStub;
next();
});
app.use(loopback.token({ model: Token }));
app.get('/', function(req, res, next) {
res.send(req.accessToken);
});

request(app).get('/')
.set('Authorization', this.token.id)
.expect(200)
.end(function(err, res) {
if (err) return done(err);
expect(res.body).to.eql(tokenStub);
done();
});
});
});

describe('AccessToken', function () {
Expand Down
14 changes: 14 additions & 0 deletions test/app.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,20 @@ describe('app', function() {
});
});

describe('getModelByType', function() {
it('returns undefined for model not attached to app', function() {
expect(app.getModelByType(loopback.User)).to.equal(null);
});

it('returns model subclass', function() {
var User = app.model('User', {
options: { base: 'User' },
dataSource: 'db'
});
expect(app.getModelByType(loopback.User)).to.equal(User);
});
});

describe('app.boot([options])', function () {
beforeEach(function () {
app.boot({
Expand Down
61 changes: 61 additions & 0 deletions test/rest.middleware.test.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
describe('loopback.rest', function() {
beforeEach(function() {
app.dataSource('db', { connector: loopback.Memory });
});

it('works out-of-the-box', function(done) {
app.model('MyModel', { dataSource: 'db' });
app.use(loopback.rest());
request(app).get('/mymodels')
.expect(200)
.end(done);
});

it('includes loopback.token when necessary', function(done) {
// Note: we have to attach an access token model to the app.
// The auto-detection in loopback.getModelByType()
// fails in unit-tests, as there are too many AccessToken models
// (each test suite registers its' own one)
var Token = app.model('AccessToken', {
options: { base: 'AccessToken' },
dataSource: 'db'
});
givenUserModelWithAuth();
app.enableAuth();
app.use(loopback.rest());

givenLoggedInUser(function(err, token) {
if (err) return done(err);
expect(token).instanceOf(Token);
request(app).get('/users/' + token.userId)
.set('Authorization', token.id)
.expect(200)
.end(done);
});
});

function givenUserModelWithAuth() {
return app.model('user', {
options: {
base: 'User',
relations: {
accessTokens: {
model: 'AccessToken',
type: 'hasMany',
foreignKey: 'userId'
}
}
},
dataSource: 'db'
});
}
function givenLoggedInUser(cb) {
var credentials = { email: 'user@example.com', password: 'pwd' };
var User = app.getModelByType(loopback.User);
User.create(credentials,
function(err, user) {
if (err) return done(err);
User.login(credentials, cb);
});
}
});
2 changes: 1 addition & 1 deletion test/support.js
Original file line number Diff line number Diff line change
Expand Up @@ -64,4 +64,4 @@ describe.inBrowser = function describeInBrowser(name, fn) {
} else {
describe.skip(name, fn);
}
};
};