Repository navigation
Use the new remoting.authorization hook for check access - #1370
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
Should we save the original authorization implementation and call after loopback auth passed? I think that's the canonical way of overriding methods like this.
var baseAuthorization = remotes.authorization;
remotes.authorization = function(ctx, next) {
if (authorized) {
baseAuthorization(ctx, next); // or perhaps .call(this, ctx, next)
} else {
next(new Error('Not authorized.'));
}
};
Member
|
The CI build is red, please fix it. |
Member
Author
Most likely due to the missing |
Member
Author
|
test please |
ritch
force-pushed
the
fix/check-access-ordering
branch
from
May 12, 2015 22:30
a8b87c7 to
46cc6b2
Compare
ritch
force-pushed
the
fix/check-access-ordering
branch
from
May 12, 2015 22:33
46cc6b2 to
9cde2a4
Compare
Member
|
LGTM. |
ritch
added a commit
that referenced
this pull request
May 12, 2015
Use the new remoting.authorization hook for check access
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/to @raymondfeng
/cc @bajtos @fabien
This PR uses the authorization hook added with this strong-remoting PR.
Connect #1363
Connect #1191