You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Inconsistency findById vs. destroy vs. __destroyById__* #489
There's an inconsistency in method naming - we have findById, and __destroyById__* for remoting, yet the relation/scope method is called destroy. This method does take an id, though.
@raymondfeng shall I go ahead and rename destroy to destroyById? I'm afraid of side-effects - anything to watch out for? Actually, this should be fixed over at juggler anyway.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
Activity
raymondfeng commentedon Aug 22, 2014
PR? :-)
fabien commentedon Aug 22, 2014
@raymondfeng shall I go ahead and rename
destroytodestroyById? I'm afraid of side-effects - anything to watch out for? Actually, this should be fixed over at juggler anyway.raymondfeng commentedon Aug 22, 2014
destroyis the method name in Node. Some docs refer to it, for example:http://docs.strongloop.com/display/LB/HasMany+relations
You can search the references in juggler project.
fabien commentedon Aug 22, 2014
Hmm... perhaps we should leave this until a major release?
stale commentedon Aug 23, 2017
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.