Skip to content

Inconsistency findById vs. destroy vs. __destroyById__* #489

Closed

Description

@fabien

There's an inconsistency in method naming - we have findById, and __destroyById__* for remoting, yet the relation/scope method is called destroy. This method does take an id, though.

Activity

  1. raymondfeng commented on Aug 22, 2014

    @raymondfeng
    Member

    PR? :-)

  2. fabien commented on Aug 22, 2014

    @fabien
    ContributorAuthor

    @raymondfeng shall I go ahead and rename destroy to destroyById? I'm afraid of side-effects - anything to watch out for? Actually, this should be fixed over at juggler anyway.

  3. raymondfeng commented on Aug 22, 2014

    @raymondfeng
    Member

    destroy is the method name in Node. Some docs refer to it, for example:

    http://docs.strongloop.com/display/LB/HasMany+relations

    You can search the references in juggler project.

  4. fabien commented on Aug 22, 2014

    @fabien
    ContributorAuthor

    Hmm... perhaps we should leave this until a major release?

  5. removed this from the #Epic: LoopBack 3.0 milestone on May 24, 2016
  6. stale commented on Aug 23, 2017

    @stale

    This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions