Skip to content

Access token invalidation should be disabled by default in 2.x #3068

Closed

Description

@bajtos

As described in #3048, adding automatic access token invalidation to 2.x is viewed as a breaking change by some of our users.

We should add a new feature flag (model-level setting?) to 2.x to control whether access token are invalidated or not. When this flag is not set, a warning should be printed to notify users about a potential security vulnerability.

In 3.0, we should throw an exception when this flag is set to false, so that users upgrading from 2.x to 3.0 are forced to upgrade their code to support our automatic token invalidation.

Tasks

Activity

  1. self-assigned this
    on Jan 4, 2017
  2. added this to the Sprint 27 milestone on Jan 10, 2017
  3. timlind commented on Jan 20, 2017

    @timlind

    Is documentation update included in the above tasks? It's the first place I went to look when it broke.

  4. bajtos commented on Jan 20, 2017

    @bajtos
    MemberAuthor

    @timlind Is documentation update included in the above tasks? It's the first place I went to look when it broke.

    Good point! What page would you recommend to change? Would you mind contributing this change yourself? In my experience, documentation contributed by users tends to be the best one, because users know best what and where they were looking for in the docs.

  5. bajtos commented on Jan 20, 2017

    @bajtos
    MemberAuthor

    Actually, let's keep the documentation as part of the follow-up story #3112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions