Skip to content

Remove autoAttach #294

Closed
Closed

Description

@ritch

Details TBD.

This was a failed attempt at allowing models to declare a dependency. As of 2.0 this dependency is more explicit (see PersistedModel). This change will require similarly explicit dependency for Email, Push and similar models.

Activity

  1. added this to the milestone on May 29, 2014
  2. bajtos commented on May 30, 2014

    @bajtos
    Member

    Before we can remove autoAttach, we need to implement a mechanism for attaching an existing model to a datasource via models.json without creating a subclass - see loopbackio/loopback-datasource-juggler#119.

  3. bajtos commented on Jul 8, 2014

    @bajtos
    Member

    FWIW, loopback-boot 2.0 split the boot in two phases: model definition (models/*.json) and model configuration (models.json). It is possible to configure any model in models.json file as long as it can be found via loopback.getModel(name), which is true for built-in models.

  4. self-assigned this
    on Jul 15, 2014
  5. bajtos commented on Jul 22, 2014

    @bajtos
    Member

    This can be done in a way that would allow people to use loopback-boot@1.x together with loopback@2.x.

  6. removed this from the milestone on Jul 22, 2014
  7. removed their assignment
    on Jul 24, 2014
  8. bajtos commented on Oct 3, 2014

    @bajtos
    Member

    The current status:

    • loopback-boot@1.x comes with it's own implementation of autoAttach, thus the method can be safely dropped from loopback
    • as for attaching an existing model to a datasource via models.json, that's already supported in loopback-boot@2.x.

    Conclusion: the only remaining blocker is that we need a next major version of loopback.

  9. self-assigned this
    on Nov 26, 2014
  10. added this to the LoopBack 3.0 milestone on Nov 26, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions