Skip to content

v1.6.2 is not backwards compatible with v1.6.1 projects #182

Closed

Description

@bajtos

Steps to reproduce:

  1. Create the following package.json file:

    {
      "dependencies": {
        "loopback-datasource-juggler": "~1.2.13",
        "loopback": "~1.6.0"
      }
    }
  2. Run npm install.

    [cut]
    npm ERR! peerinvalid
      The package loopback-datasource-juggler 
      does not satisfy its siblings' peerDependencies requirements!
    npm ERR! peerinvalid
      Peer loopback@1.6.2 wants loopback-datasource-juggler@~1.3.0
    

The problem is IMO caused by loopback v1.6.2 breaking semver rules.

How to fix the immediate problem:

  • release loopback v1.6.2 as v1.7.0
  • npm unpublish loopback@1.6.2
  • update loopback-workspace to depend on loopback >=1.7, publish a new patch version

/to @raymondfeng @ritch Any objections to taking the two actions above?

Longterm:

When we bump up the version of loopback-datasource-juggler required by loopback to a different major/minor version, we must release this change as a minor version of loopback.

Possibly related: the comment in #85.

Activity

  1. bajtos commented on Feb 18, 2014

    @bajtos
    MemberAuthor

    We should also change the loopback version required by loopback-workspace and publish a patch version. I have updated the list of actions in the issue description.

  2. raymondfeng commented on Feb 18, 2014

    @raymondfeng
    Member

    Maybe we should collaboratively release a list of loopback related modules as we now have dual licenses for most of them. It will set a new baseline.

  3. added a commit that references this issue on Feb 18, 2014
  4. bajtos commented on Feb 18, 2014

    @bajtos
    MemberAuthor

    Maybe we should collaboratively release a list of loopback related modules as we now have dual licenses for most of them. It will set a new baseline.

    That's fine too.

    Whatever way we choose, we should unpublish loopback@1.6.2 as soon as possible. It has already affected @mschmulen (strong-cli#107) and CI builds of loopback-angular (loopback-angular#19).

  5. bajtos commented on Feb 23, 2014

    @bajtos
    MemberAuthor

    @sam-github run into this problem too.

  6. sam-github commented on Feb 23, 2014

    @sam-github
    Contributor

    For me, the src of my problem was an out of data sls-sample-app that had been npm linked (for no good reason, I think I linked every strongnode module a month ago).

    By doing an npm update in my sample app, the peer conflicts went away. Then I unlinked the sls-sample-app, because it didn't need to be linked.

  7. self-assigned this
    on Feb 28, 2014
  8. bajtos commented on Oct 15, 2014

    @bajtos
    MemberAuthor

    Nobody should be using v1.6 by now, I am closing the issue as no longer relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions