Skip to content

User passwords in the browser #1249

Closed
Closed

Description

@bajtos

At the moment, the User model includes internal methods hasPassword and hashPassword in the browserified bundle too. The implementation uses bcryptjs, which adds about 50kb to the bundle (un-minified) and another 650kb through crypto-browserify (see #1247).

I'd like us to consider whether these two methods make sense to be called in the browser, how should we replicate changes made to a user model, and ideally come up with an implementation that does not require bcryptjs when running in the browser.

Activity

  1. self-assigned this
    on Mar 26, 2015
  2. added this to the #Epic: LoopBack 3.0 milestone on Mar 26, 2015
  3. ritch commented on Mar 26, 2015

    @ritch
    Member

    I'd be fine if we just threw when calling those methods in the browser.

  4. ritch commented on Mar 26, 2015

    @ritch
    Member

    Then replace bcrypt with a noop or a throw-only function.

  5. BerkeleyTrue commented on Jun 26, 2015

    @BerkeleyTrue
    Contributor

    Whats the word on this?

  6. bajtos commented on Jun 30, 2015

    @bajtos
    MemberAuthor

    @BerkeleyTrue I think this has to wait for LB 3.0, unless we can come up with a way how to preserve the current behaviour and provide a feature flag to enable the new mode without hasPassword/hashPassword.

  7. bajtos commented on May 24, 2016

    @bajtos
    MemberAuthor

    @BerkeleyTrue I am afraid we don't have enough bandwidth to implement this change in v3.0. Would you like to contribute it yourself?

  8. removed this from the #Epic: LoopBack 3.0 milestone on May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions