You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment, the User model includes internal methods hasPassword and hashPassword in the browserified bundle too. The implementation uses bcryptjs, which adds about 50kb to the bundle (un-minified) and another 650kb through crypto-browserify (see #1247).
I'd like us to consider whether these two methods make sense to be called in the browser, how should we replicate changes made to a user model, and ideally come up with an implementation that does not require bcryptjs when running in the browser.
@BerkeleyTrue I think this has to wait for LB 3.0, unless we can come up with a way how to preserve the current behaviour and provide a feature flag to enable the new mode without hasPassword/hashPassword.
Activity
ritch commentedon Mar 26, 2015
I'd be fine if we just threw when calling those methods in the browser.
ritch commentedon Mar 26, 2015
Then replace
bcryptwith a noop or a throw-only function.BerkeleyTrue commentedon Jun 26, 2015
Whats the word on this?
bajtos commentedon Jun 30, 2015
@BerkeleyTrue I think this has to wait for LB 3.0, unless we can come up with a way how to preserve the current behaviour and provide a feature flag to enable the new mode without
hasPassword/hashPassword.bajtos commentedon May 24, 2016
@BerkeleyTrue I am afraid we don't have enough bandwidth to implement this change in v3.0. Would you like to contribute it yourself?