Skip to content

Create benchmarks & fail on leaks #1084

Closed

Description

@STRML

Continuation of this discussion on the critical leak that affected 2.8.7 to 2.12.1.

We need a way to detect if something like this happens again.

It would be a good idea IMO to have general benchmarks in any case, so we can detect how our changes affect loopback's throughput. We could also fail the benchmark outright if a leak event is caught by node-memwatch.

Activity

  1. bajtos commented on Mar 30, 2015

    @bajtos
    Member

    Relabelled per our discussion with @raymondfeng, @ritch and @superkhau

  2. raymondfeng commented on Mar 30, 2015

    @raymondfeng
    Member

    @superkhau Would you like to create a simple benchmark test that leverages https://github.com/lloyd/node-memwatch to see if it helps?

  3. self-assigned this
    on Mar 30, 2015
  4. superkhau commented on Mar 30, 2015

    @superkhau
    Contributor

    Sure, adding to TOB for planning.

  5. superkhau commented on Apr 8, 2015

    @superkhau
    Contributor

    @raymondfeng What do you want to test in the benchmark? I'm thinking we should make loopback-benchmark public and get some community input on this. Opinions?

  6. superkhau commented on Apr 8, 2015

    @superkhau
    Contributor

    As discussed with @raymondfeng and @ritch, it has been decided that we will add benchmarks to various perspectives of LoopBack (module/unit level, integration level, etc). The purpose of this issue has now changed to a spike on how to move forward with regards to tooling and statistics gathering. The findings will be captured in a wiki.

  7. superkhau commented on Apr 8, 2015

    @superkhau
    Contributor

    Closing this in favour of #1291

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions