Repository navigation
Fix CI Errors in windows - #418
Conversation
e7b01b6 to
132f682
Compare
|
We may need to increase the timeout in end-to-end tests even more. See http://ci.strongloop.com/job/loopback-workspace/node=4.x,os=windows/6113/console |
e55aa09 to
f7523de
Compare
|
@bajtos , booting of the app in windows works fine. it is the route configuration in middleware.json (placed in templates folder) that didnt get configured. When I added a boot script to the templates, the issue was resolved. I will be removing the file later. |
f7523de to
03c2267
Compare
Thank you for the update. The two tests you are disabling in this patch were passing for me on my local Windows machine. I think you need to delete Let me know if you need any more help. I can debug this myself to prevent too much waste of your time, if you like. |
03c2267 to
db050c5
Compare
|
@bajtos @superkhau I have made some more progress on the workspace CI issues in windows. I removed the additional boot script and changed the “routes” middleware configuration from |
f00441b to
c70158a
Compare
|
@bajtos @superkhau I removed cached install and just did a plain 'npm install' and all tests are passing now (except for the skipped 1) |
4f75c00 to
783bf4c
Compare
|
I introduced strong-cached-install in order to reduce the time needed to run end-to-end, so that we can get fast feedback when developing in TDD red-green-refactor style. Strangely enough, on Node v6.x using |
bajtos
left a comment
There was a problem hiding this comment.
Looks mostly good, PTAL at my comments below.
| }); | ||
|
|
||
| it('updates all models in the database', function(done) { | ||
| it.skip('updates all models in the database', function(done) { |
There was a problem hiding this comment.
Why is this needed? Where is the follow-up issue to fix the tests on Windows properly? Please add a comment to the test file.
| cwd: cwd, | ||
| }; | ||
| var script = 'npm install'; | ||
| return exec(script, options, function(err, stdout, stderr) { |
There was a problem hiding this comment.
Please debug log the script and the options or at cwd before calling exec, e.g.
debug('Running `%s` in %s', script, cwd);
exec(...);|
|
||
| 'use strict'; | ||
|
|
||
| exports.isWindows = /^win/.test(process.platform); |
There was a problem hiding this comment.
I believe this helper is no longer used, please remove.
There was a problem hiding this comment.
used to skip one test
| }; | ||
| }; | ||
|
|
||
| initializePackage = function() { |
There was a problem hiding this comment.
Since this helper is used only by installSandboxPackages, please move its definition the test/end-to-end.js.
| }; | ||
|
|
||
| initializePackage = function() { | ||
| fs.mkdirSync(path.join(SANDBOX, 'node_modules')); |
There was a problem hiding this comment.
Please add a comment explaining why is this needed.
| var TestDataBuilder = require('./helpers/test-data-builder'); | ||
| var ref = TestDataBuilder.ref; | ||
| var given = require('./helpers/given'); | ||
| var platform = require('./helpers/platform'); |
There was a problem hiding this comment.
AFAICT, this is not used, please remove.
There was a problem hiding this comment.
Nevermind, i see the comment below where you need it to skip a test
18b6c2d to
2a4ae7d
Compare
b1f5639 to
31350c1
Compare
install latest strong cached install
31350c1 to
b9ee73d
Compare
| var TestDataBuilder = require('./helpers/test-data-builder'); | ||
| var ref = TestDataBuilder.ref; | ||
| var given = require('./helpers/given'); | ||
| var platform = require('./helpers/platform'); |
| var TestDataBuilder = require('./helpers/test-data-builder'); | ||
| var ref = TestDataBuilder.ref; | ||
| var given = require('./helpers/given'); | ||
| var platform = require('./helpers/platform'); |
There was a problem hiding this comment.
Nevermind, i see the comment below where you need it to skip a test
Fix Windows CI Errors: