Skip to content

Update dependency and test command for PhantomJS - #215

Closed
scalarsys wants to merge 2 commits into
strongloop:masterfrom
scalarsys:feature/update-phantomjs
Closed

scalarsys wants to merge 2 commits into
strongloop:masterfrom
scalarsys:feature/update-phantomjs

Conversation

@scalarsys

Copy link
Copy Markdown

The resolution to an error when running "npm test" is to update the PhantomJS dependency to PhantomJS2.

Background

Current angular dependency is defined:
"angular": "^1.4.9"

With the release of angular 1.5 there are errors loading angular in PhantomJS that affect this repo's default test command.

Original Issue not addressed in PhantomJS 1.0: ariya/phantomjs#10522

Recent discussion specific to angular 1.5: angular/angular.js#13794

Error Message:

PhantomJS 1.9.8 (Windows 8 0.0.0) ERROR
Error: [$injector:modulerr] Failed to instantiate module ng due to:
TypeError: 'undefined' is not an object (evaluating 'Function.prototype.bind.apply')

@slnode

slnode commented Apr 1, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@davidcheung

Copy link
Copy Markdown
Contributor

@slnode okay to test

@davidcheung

Copy link
Copy Markdown
Contributor

I can confirm that the current phantomJS doesnt install properly, you need to change https from npm registry to npm set registry http://registry.npmjs.org/ or else it wouldnt download the package

@davidcheung

Copy link
Copy Markdown
Contributor

@scalarsys Thanks for the patch!
and can you please sign the CLA agreement

@scalarsys

Copy link
Copy Markdown
Author

I have signed the CLA but had problems with SL team members seeing that I have signed it on another PR. When I go to https://cla.strongloop.com/agreements if shows that I have signed the agreement for loopback-sdk-angular. Let me know if you need me to do anything to clear up the CLA issue.

@davidcheung

Copy link
Copy Markdown
Contributor

Oh, I believe its because the commit it under @jeff-clegg, therefore the CLA check isnt passing.

@jeff-clegg

Copy link
Copy Markdown
Contributor

Ok, my mistake, I signed CLA as @jeff-clegg.

@davidcheung

Copy link
Copy Markdown
Contributor

@scalarsys would you be able to rebase the changes on top of current master please?

@slnode

slnode commented Jul 16, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch?

@scalarsys

Copy link
Copy Markdown
Author

Not sure if I did the rebase correctly, sorry if this is too much trouble.

@davidcheung

Copy link
Copy Markdown
Contributor

sorry my fault, since I took so long to reply, might have been a better idea to just fetch the latest and redo it on the origin/master.
@scalarsys i am rerunning the CI on this PR #231

@davidcheung

Copy link
Copy Markdown
Contributor

@scalarsys Thanks for your PR i have landed via #231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants