This repository was archived by the owner on Apr 18, 2020. It is now read-only.
Repository navigation
Feature/next gen layout - #33
Merged
Merged
Conversation
added 4 commits
June 17, 2014 08:59
- Reduce REST API related settings to two properties: `restApiRoot` and `restApiUrl`. - Move `web/` config to `web/app.json` and `web/app.local.js`. - Refactor `rest/` and `web/` so that `rest/` exports only the REST API endpoint. Move loopback-explorer setup to the `web/` component.
Create a new file `html5/config.routes.json` to keep the list of known routes.
Member
Author
Member
There was a problem hiding this comment.
Where is that proposal? Just took a look at @kraman's blog example and didn't see it.
If it is allowing string interpolation in app settings, I think it makes sense in general. It would clean this code up, but I'd need to give it a bit more thought around how it would supported by the workspace.
Member
Author
There was a problem hiding this comment.
He has removed that part in the mean time.
See app.parameterize in common/settings.js@2a25c54
Member
|
My comments are all really outside the scope of this PR. 👍 for merging. |
7 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
More changes in order to bring the repo layout closer to the new Workspace layout.
Things to do next (out of scope of this PR):
yo angularyo angular, get rid of the remainingconfigure.jscodewebappandserver/to @ritch please review