Skip to content
This repository was archived by the owner on Apr 18, 2020. It is now read-only.

Feature/next gen layout - #33

Merged
bajtos merged 4 commits into
masterfrom
feature/next-gen-layout
Jun 23, 2014
Merged

bajtos merged 4 commits into
masterfrom
feature/next-gen-layout

Conversation

@bajtos

@bajtos bajtos commented Jun 17, 2014

Copy link
Copy Markdown
Member

More changes in order to bring the repo layout closer to the new Workspace layout.

  • Move api/ to rest/
  • Move most of configuration out of configure.js
  • Move configuration of ng routes out of configure.js

Things to do next (out of scope of this PR):

  • scaffold the html5 app using yo angular
  • replace Gulp-based build with Grunt, the base is scaffolded by yo angular, get rid of the remaining configure.js code
  • refactor web into webapp and server

/to @ritch please review

Miroslav Bajtoš added 4 commits June 17, 2014 08:59
 - Reduce REST API related settings to two properties:
   `restApiRoot` and `restApiUrl`.

 - Move `web/` config to `web/app.json` and `web/app.local.js`.

 - Refactor `rest/` and `web/` so that `rest/` exports only the REST API
   endpoint. Move loopback-explorer setup to the `web/` component.
Create a new file `html5/config.routes.json` to keep the list of known
routes.
Comment thread web/app.js

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this is far from perfect. We should come up with a better way if we want to support customized app title in our workspace templates. Perhaps implement the parametrisation which @kraman proposed in his alternate layout.

Thoughts, @ritch?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is that proposal? Just took a look at @kraman's blog example and didn't see it.

If it is allowing string interpolation in app settings, I think it makes sense in general. It would clean this code up, but I'd need to give it a bit more thought around how it would supported by the workspace.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

He has removed that part in the mean time.

See app.parameterize in common/settings.js@2a25c54

@ritch

ritch commented Jun 17, 2014

Copy link
Copy Markdown
Member

My comments are all really outside the scope of this PR. 👍 for merging.

bajtos added a commit that referenced this pull request Jun 23, 2014
@bajtos
bajtos merged commit f654ab3 into master Jun 23, 2014
@bajtos
bajtos deleted the feature/next-gen-layout branch June 23, 2014 07:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants