This repository was archived by the owner on Apr 18, 2020. It is now read-only.
Repository navigation
Feature/api app cleanup - #16
Merged
Merged
Conversation
added 2 commits
May 30, 2014 09:30
Add api/boot/authentication.js to enable authentication once we are ready for that. Add api/boot/change-tracking.js to expose Todo's ChangeModel.
Add `api/app.json` and `api/app.local.json` to configure the api server.
Modify api/app.api.js to load these config files via loopback-boot
and use `server.get('restApiRoot')` instead of `CONFIG.api.root`.
Member
Author
There was a problem hiding this comment.
As of loopback v1.8.4 and 2.0.0-beta3, loopback.token() is automatically included by loopback.rest() when auth is enabled (see strongloop/loopback#263).
Member
|
LGTM (though some of this might change today) |
Member
There was a problem hiding this comment.
This file should be obsoleted by a global config js file.
Member
Author
There was a problem hiding this comment.
yes, feel free to make that change.
7 of 12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
api/app.api.jstoapi/boot/*.jsapi/app.jsonand friends to configure the api app/to @ritch please review.
I have a concern about the proposed usage of
app.json. The main app fileapp.api.jsmatches the pattern used by loopback-boot whenNODE_ENV=api. Here are few options how to address that:loopback-bootto specify a different prefix for app config files, e.g.app.apiinstead of the defaultapp. The config files in this project will be renamed toapp.api.jsonandapp.api.local.js..json.jsinstead of.js, i.e.app.local.json.js.app.api.js, but that will break the concept of havingapp.jswith the app source code andapp.jsonwith the app configuration.Thoughts?