Skip to content

[Fix] overrides-swagger-ui files test ignores copyright in dummy file. - #160

Merged
bajtos merged 2 commits into
strongloop:masterfrom
supasate:fix/ignore-copyright-in-dummy-swagger-ui-test
May 9, 2016
Merged

bajtos merged 2 commits into
strongloop:masterfrom
supasate:fix/ignore-copyright-in-dummy-swagger-ui-test

Conversation

@supasate

@supasate supasate commented May 6, 2016

Copy link
Copy Markdown
Contributor

Currently, npm run test fails the 'overrides swagger-ui files' test because the content inside dummy-swagger-ui/swagger-ui.js was prepended by copyright notice. This fix ignores the copyright notice and checks only that the file contains /* custom swagger-ui file */.

supasate added 2 commits May 6, 2016 21:46
Signed-off-by: Supasate Choochaisri <supasate.c@gmail.com>
…logic

Signed-off-by: Supasate Choochaisri <supasate.c@gmail.com>
@superkhau

Copy link
Copy Markdown
Contributor

LGTM, but @bajtos for the final review on this one as I'm not sure about the implications on other swagger deps.

@bajtos

bajtos commented May 9, 2016

Copy link
Copy Markdown
Member

I am not convinced the whitespaces changes made in 702117d is the right kind of changes to make (/cc @superkhau), but let's set that aside for now.

The patch LGTM, thank you @supasate for the the contribution!

@bajtos
bajtos merged commit 5eece0b into strongloop:master May 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants