Repository navigation
Conversation
Signed-off-by: Supasate Choochaisri <supasate.c@gmail.com>
…logic Signed-off-by: Supasate Choochaisri <supasate.c@gmail.com>
This was referenced May 6, 2016
Contributor
|
LGTM, but @bajtos for the final review on this one as I'm not sure about the implications on other swagger deps. |
Member
|
I am not convinced the whitespaces changes made in 702117d is the right kind of changes to make (/cc @superkhau), but let's set that aside for now. The patch LGTM, thank you @supasate for the the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
npm run testfails the 'overrides swagger-ui files' test because the content insidedummy-swagger-ui/swagger-ui.jswas prepended by copyright notice. This fix ignores the copyright notice and checks only that the file contains/* custom swagger-ui file */.