Repository navigation
Coffee fix2 - #59
Coffee fix2#59
Conversation
|
Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test." |
|
Discussion continued from #55 |
|
Ok. I rebased and did a |
|
@slnode ok to test |
There was a problem hiding this comment.
I'd rather keep all extension filtering in a single place and pass files to loadModelDefinition.
|
The implementation looks good in general, I left a bunch of comments mostly related to coding style. The tests are failing with the following error, please fix it: |
|
Hmm... the failure was due to a require.cache issue (the two tests conflicted when run together). I fixed it by deleting some entries from the cache, but it's verbose. My goal was to leave the environment the way I found it (e.g. as though coffee-script had never been loaded). But maybe that doesn't actually matter. I could:
Take a look and see what you think. |
|
Ok, I think everything is in compliance. I tried rebasing on current master, but the master branch seems to have test failures... so I'll await your instructions. |
👍 |
It passes all tests on my machine. What test failures do you see? |
|
Ok, I removed the cleanup code. These are the failures I'm seeing on master: |
|
Ok, I just needed to run NPM install. The cache cleanup code is removed, and everything is rebased now. Should be good to go. |
|
Here's the official word on require.extensions/coffee-script integration: So until further notice, using |
There was a problem hiding this comment.
Extra empty line, please remove.
|
One more nitpick, see above. Other than that, the patch LGTM. Please rebase on top of the current master and squash the commits into a single one and provide a descriptive commit message following the 50/72 rule. In case you are not familiar with git history rewriting: |
|
BTW it is no longer necessary to sign-off the commits, it's enough to sign the CLA via the web-based app (which you have done already). |
Load models for any filetypes registered in require.extensions.
- Server side coffee-script requires a `require('coffee-script/register');`
- Client side coffee-script requires Coffeeify.
|
I did those things. The github statusbox in this thread now reports failures, but I'm unable to see any details. |
|
@slnode test please The error was not related to you pull request, our Jenkins is sometimes failing to fetch PR from github. @rmg is working on a fix. I have wiped out Jenkin's workspace, hopefully it will help. |
|
@slnode test please |
support coffee-script models and client code
|
Landed, thank you for the contribution! |
|
Awesome, thanks for working through it with me!
|
|
Released to npmjs.org as |
Fixed CLA issues (I think), and added additional commits to comply with @bajtos requests.