Skip to content

parse config: should ignore null values - #183

Merged
bajtos merged 1 commit into
strongloop:masterfrom
LoicMahieu:fix/182
Apr 13, 2016
Merged

bajtos merged 1 commit into
strongloop:masterfrom
LoicMahieu:fix/182

Conversation

@LoicMahieu

Copy link
Copy Markdown
Contributor

Fix #182

@slnode

slnode commented Apr 11, 2016

Copy link
Copy Markdown

Can one of the admins verify this patch? To accept patch and trigger a build add comment ".ok\W+to\W+test."

@davidcheung

Copy link
Copy Markdown
Contributor

@slnode ok to test

Comment thread lib/executor.js Outdated
} else if (typeof value === 'string') {
interpolated[configKey] = getConfigVariable(value);
} else if (typeof value === 'object' && Object.keys(value).length) {
} else if (typeof value === 'object' && value !== null && Object.keys(value).length) {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please wrap line so it doesn't exceed 80 length.

OR we could also separate it as a condition to handle null to avoid the 80char limit, dont have a strong opinion on this, any thoughts?

else if (value === null) {
  interpolated[configKey] = value;
}

@davidcheung

Copy link
Copy Markdown
Contributor

@LoicMahieu Thanks for the patch!
@bajtos PTAL

@LoicMahieu

Copy link
Copy Markdown
Contributor Author

Rebased!

@bajtos
bajtos merged commit 47974fd into strongloop:master Apr 13, 2016
@bajtos

bajtos commented Apr 13, 2016

Copy link
Copy Markdown
Member

@LoicMahieu landed, thank you for the contribution! I have released your patch in loopback-boot@2.18.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants