Repository navigation
Environment-specific loading for 'model-config' - #141
Closed
dashby3000 wants to merge 2 commits into
Closed
dashby3000 wants to merge 2 commits into
dashby3000 wants to merge 2 commits into
Conversation
… model-config.env.js as do other config files.
Member
|
Good idea |
Member
|
@dashby3000 There is a style issue that fails the build. Can you fix it? A test is also appreciated to cover your enhancement. |
Author
|
Updated to fix the styling issue. As for the test, I will just duplicate the tests that already exits for checking the merge. |
Member
|
Closed by #143 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added code to allow model-config to respect model-config.local.js and model-config.env.js as do other config files.