Repository navigation
Mock solenoids #86
Description
The instantaneousSolenoid() method and the manualSolenoid() return essentially the same object. From what I have gathered from the code is that the manualSolenoid() should be set to false.
`/**
* Create a solenoid that operates instantaneously and immediately stops.
*
* @return the mock solenoid; never null
*/
public static MockSolenoid instantaneousSolenoid() {
return new MockSolenoid(true);
}
/**
* Create a solenoid that operates infinitely slowly and must be manually {@link MockSolenoid#stop() stopped}.
*
* @return the mock solenoid; never null
*/
public static MockSolenoid manualSolenoid() {
return new MockSolenoid(true);
}`
Activity
rhauch commentedon Dec 29, 2016
@FilipKernan, yeah, I think you're right. The
manualSolenoidmethod should callnew MockSolenoid(false);. Do you want to submit a pull request? (If so, please feel free to add your name to theCONTRIBUTORSfile in the root of the repository in a second commit within the same pull request.)FilipKernan commentedon Dec 29, 2016
@rhauch sure. Will do.
rhauch commentedon Dec 29, 2016
Fixed by #87