Repository navigation
Add Mantle and Pylate targets to lakefile.toml - #17
Open
wkrozowski wants to merge 1 commit into
Open
wkrozowski wants to merge 1 commit into
wkrozowski wants to merge 1 commit into
Conversation
The mirror from the internal StrataPythonFrontEnd package excludes lakefile.toml, so the lean_lib/lean_exe declarations added alongside Mantle (StrataMantle, StrataMantleTest, pymantle) and Pylate (Pylate, PylateTests, pylate, pylateTests) never reached this repository, even though their sources did. Without a lean_lib owning the StrataMantle.* modules, Lake does not build them and `lake build` fails on StrataPython.Mantle.Env with "unknown module prefix 'StrataMantle'". This ports those declarations (and the matching defaultTargets and StrataPythonFrontEndTestMain needs) from the internal lakefile.
Contributor
|
Looks like you need to point the Plausible dependency to the corresponding GitHub URL? Not sure what to make of the test failures yet. |
joehendrix
approved these changes
Oct 30, 2026
cderici
approved these changes
Oct 30, 2026
peixuan-li
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix CI failure on
StrataPython.Mantle.Envwith:The GitHub mirror excludes
lakefile.toml. So when the Mantle and Pylate work landed, its sources (StrataMantle/,StrataMantleTest/,Pylate/,Scripts/pymantle.lean,Scripts/pylate.lean) reached this repo, but thelean_lib/lean_exedeclarations that build them did not. No library owns theStrataMantle.*modules here, so Lake never builds them and the import fails.This PR ports the missing declarations:
lean_lib:StrataMantle,StrataMantleTest,Pylate,PylateTestslean_exe:pymantle,pylate,pylateTestsdefaultTargetsmatches the internal listStrataPythonFrontEndTestMain.needsaddsStrataMantleTestandpylateTestsGitHub-specific parts (the package name, the
git/revrequire on Strata, and theStrataPythonTestExtralib) are unchanged.A follow-up on the mirror side will keep these target declarations from drifting again.
Checklist
lake build StrataPython StrataPythonTestsucceeds locally (Lean v4.34.0); a plainlake buildof all default targets also succeeds.leanfiles start with the standard copyright header (no new.leanfiles)