Skip to content

Can maps be freely added to this plugin? #8

Open

Description

@danse

From what i can see here, in order to use a map with this plugin, the map needs to exist into https://github.com/stormpython/vectormap/tree/master/public/lib/jvectormap/maps. Does this approach scale? If i would open a pull request for adding an arbitrary map to that folder, would it be accepted?

Activity

  1. emig commented on Jul 14, 2016

    @emig

    @danse this approach doesn't scale, particular maps won't be of general interest. The simple solution is to fork.

  2. stormpython commented on Jul 15, 2016

    @stormpython
    Owner

    @danse, I second what @emig said. I tried to include general maps that most would find useful. However, since these are vector maps, it meant including the vector files which can get pretty big depending on what you want to display.

    An approach that may be worth exploring is to add a plugin system for including other vector maps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions