Skip to content
This repository was archived by the owner on Feb 13, 2025. It is now read-only.
This repository was archived by the owner on Feb 13, 2025. It is now read-only.

tasklet, channel: use tp_finalize instead of tp_dealloc for complex finalisation code #192

Description

@akruis

The C-API documentation states: Starting with Python 3.4, it is recommended not to put any complex finalization code in tp_dealloc, and instead use the new tp_finalize type method.

Actually we have complicated finalisation code in the tp_dealloc functions of tasklet and channel.
Task: move the finalisation logic to the tp_finalize slot.

Activity

  1. self-assigned this
    on Dec 26, 2018
  2. added this to the v3.7.x-slp milestone on Dec 26, 2018
  3. akruis commented on Dec 28, 2018

    @akruis
    Author

    Implemented by pull request #194

  4. added 4 commits that reference this issue on Jan 12, 2019
  5. akruis commented on Jan 13, 2019

    @akruis
    Author

    Done. I merged pull request #194 manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions