Repository navigation
Fix: DateAssertion.toBeDayOfWeek when using "sunday" - #76
Merged
JoseLion merged 3 commits intoOct 24, 2022
Merged
Conversation
This makes the implementation consistent with JS' Date.getDay() and with DateAssertion.toBeDayOfWeek()'s documentation.
This makes the meaning of number literals clear when using .toBeDayOfWeek().
JoseLion
approved these changes
Oct 24, 2022
JoseLion
left a comment
JoseLion
left a comment
Contributor
There was a problem hiding this comment.
Nice catch! Thanks a lot for your contribution @neolight1010 🎉
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #75 . I chose this implementation so the
.toBeDayOfWeekmatcher's behavior is consistent with Javascript'sDate.getDayand with.toBeDayOfWeek's documentation. I also changed its docs so it's clear what a number literal means when using the matcher.I also think there should be a
.toBeISODayOfWeekmatcher, to avoid further confusion.Changes
.toBeDayOfWeekdocs.