Repository navigation
chore(turbo): Move to a monorepo structure using turborepo - #73
Merged
Merged
Conversation
JoseLion
requested review from
Alex0jk,
ChristianSama,
alejo0o,
byrpatrick,
dalejo96,
elcuy and
flandrade
September 28, 2022 22:11
Alex0jk
reviewed
Oct 17, 2022
Alex0jk
left a comment
Alex0jk
left a comment
Contributor
There was a problem hiding this comment.
Looks great, I really like the new structure, but before approving I have two question:
- Was this new structure auto-generated? Or was it manual?
- I see there is a
.mocharcfile in the packages/core folders, is that expected there?
JoseLion
force-pushed
the
chore/turbo-repo
branch
from
October 24, 2022 17:01
3d192c2 to
1a8cdc0
Compare
Contributor
Author
|
@Alex0jk, thanks for reviewing the PR. Here are some answers to your questions:
Let me know if you want to talk more about these topics. Any feedback is welcome 🙂 |
Alex0jk
approved these changes
Oct 24, 2022
Alex0jk
left a comment
Alex0jk
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the answers, the structure seems pretty good so I am approving this PR.
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the structure of the repo to a mono repo using the popular turborepo library. This not only helps us to have the examples more organized but will also allow us to create separate packages, like plugins, within the same repository once the extension mechanism is ready. A few points to consider:
packages/corepackages/folderexamples/folder