Repository navigation
docs: Example projects - #70
Conversation
|
@neolight1010, thanks a lot for your contribution. We recently changed the CI configuration to allow the build workflow to trigger on forked PRs too. Can you please update your branch with the latest changes from |
|
Thank you! I updated my branch, but it seems the workflow still needs approval to be run |
|
The workflow is failing because |
|
@neolight1010 yes, I think using Yarn workspaces is a good approach for this. You can commit the modified lock file to solve the workflow issue. A couple of extra things:
"linterOptions": {
"exclude": [
"node_modules/**/*",
"examples/*/node_modules/**/*"
]
}And thanks again for your contribution! 🙂 🎉 |
This fixes the peer-dependencies warning when running `yarn install`.
|
Sorry, I didn't notice the linting rules of the project. I added the exception to the linter's rules, formatted the examples' code and fixed the linter's warnings. I also added a peer dependency missing in the Mocha example that was causing a warning when running |
JoseLion
left a comment
There was a problem hiding this comment.
Looks great! I think this is perfect for getting started with the examples. Thanks again for your contribution! 🚀 🎉
|
You're welcome! And thank you for this amazing library! 🎉 |
|
@all-contributors please add @neolight1010 for doc |
|
I've put up a pull request to add @neolight1010! 🎉 |
|
🎉 This PR is included in version 1.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This PR adds minimal example projects for Jest and Mocha, solving issue #63 .
Some details:
assertive-tsdepdendency by using Yarn workspaces. I based this on how examples are set up in Jest's source code. This required adding aworkspacesfield to the top levelpackage.jsonfile. Please tell me if I should use another approach.tsconfig.jsonfiles with a lot of commented-out fields (generated bynpx tsc -init).