Repository navigation
typescript: autocomplete missing on some things #42
Description
Expected behaviour:
Glamorous component factory style arguments autocomplete the same as they do in vscode.
Actual behaviour:
Glamorous component factory style arguments do not autocomplete the same as they do in vscode.
Reproduction:
The screenshot for the stackblitz behaviour was captured from the following project.
https://stackblitz.com/edit/react-ts-u9qiu6?file=components%2FApp%2FApp.glamorous.tsx
Metadata
Metadata
Assignees
Labels
No labels
Activity
luke-john commentedon Aug 7, 2017
Possibly it's to do with the version of typescript, Glamorous makes use of some 2.4+ features. I couldn't find what version of typescript stackblitz uses to confirm.
EricSimons commentedon Aug 7, 2017
Thanks for reporting this (and for the detailed repro)! We're on TS 2.4.1, but I think I might know what's causing this — will dig in tmrw with @apai4 and report back 👍
luke-john commentedon Aug 27, 2017
hey @EricSimons I had some time to look into this this morning and worked out this is likely an issue with the version of typescript that monaco is using under the hood.
It appears to be pre 2.2 which is when typescript inroduced support for extending interfaces from types. microsoft/TypeScript#13604
A simple reproduction is available at the following link.
https://stackblitz.com/edit/react-ts-n3tizf?file=index.tsx
So it looks like this may be fixed with the next update to the version of
monaco-editorthat's being used under the hood by stackblitz.Notes: monaco editor pulls in typescript via
monaco-typescripthttps://github.com/Microsoft/monaco-typescript/blob/master/package.jsonluke-john commentedon Sep 14, 2017
Just checked it out and everything now seems to all work great :)
Thanks so much for all the work that's been put into stackblitz 💖
EricSimons commentedon Sep 14, 2017
@luke-john I totally forgot to circle back and let you know we bumped the monaco version earlier this week, so sorry about that! 😅 No problem at all, thanks a ton for all of your help in tracking down this bug (+ others) - we seriously appreciate it!!