Basic implementation of ZooKeeper Operator by lfrancke · Pull Request #7 · stackabletech/zookeeper-operator

lfrancke · 2020-11-23T14:16:13Z

This is a start.

It defines a simple ZooKeeperCluster object and reacts to it.
It creates pods as necessary but the configuration is still missing.

This fixes #3, #1 and #2

I will keep this as a draft until the operator-rs code has been reviewed and will then migrate this code to use the new library.

Based on https://github.com/clux/controller-rs This does not handle deletions yet.

Needs cleaning up.

The operator now creates a single pod object per ZooKeeperCluster and also watches these pods for changes.

myid file is still missing.

Used to be v3_5_8 but is now 3.5.8 as intended.

That's where it belongs!

I need to pull out the configuration options into a common object.

This is a temporary workaround, the goal is to use nodeSelectors and let the Scheduler assign pods.

…ientPort was missing.

soenkeliebau

I've left a few comments, more thoughts than actual requests for changes, I'd be happy for this to go in as is.
We are currently missing the rust build checks though, those could just go in this PR so we have them in place..

soenkeliebau · 2020-12-03T14:18:37Z

+              properties:
+                version:
+                  type: string
+                  enum: [ 3.4.14 ]


Is this on purpose or just a leftover from the demo?

soenkeliebau · 2020-12-03T14:42:12Z

+use kube::CustomResource;
+use serde::{Deserialize, Serialize};
+use stackable_operator::CRD;
+use std::collections::HashMap;


soenkeliebau · 2020-12-03T14:55:54Z

+/// This method contains the logic of reconciling an object (the desired state) we received with the actual state.
+///
+/// We distinguish between three different types:
+/// * Create


I'm still a bit shaky on the whole reconciliation concept, but shouldn't we treat create and update the same? From looking at the code the only extra thing we do when creating a cluster is adding the finalizer, which we use to check if we call create or update when reconciliation is started - seems to me to be a bit of hen and egg?

soenkeliebau · 2020-12-03T15:10:38Z

+
+/// This creates an instance of a [`Controller`] which waits for incoming events and reconciles them.
+///
+/// This is an async method and the returned future needs to be consumed to make progress.


nit: might be clearer: consumed -> awaited

soenkeliebau · 2020-12-03T15:14:59Z

+    zk_cluster: &ZooKeeperCluster,
+    context: &Context<ContextData>,
+) -> Result<ReconcilerAction, Error> {
+    let zk_spec: ZooKeeperClusterSpec = zk_cluster.spec.clone();


This could be a reference I think

soenkeliebau · 2020-12-03T15:17:08Z

+    labels.insert("zookeeper-name".to_string(), name.clone());
+
+    let mut options = HashMap::new();
+    options.insert("tickTime".to_string(), "2000".to_string());


maybe add a TODO here to pull this out into a generic option crate?

soenkeliebau · 2020-12-03T15:17:20Z

+    for (i, server) in zk_spec.servers.iter().enumerate() {
+        options.insert(
+            format!("server.{}", i + 1),
+            format!("{}:2888:3888", server.node_name),


add TODO to make this configurable?

soenkeliebau · 2020-12-03T15:20:39Z

+        patch_resource(&pods_api, &pod_name, &pod, FIELD_MANAGER).await?;
+
+        let config = handlebars
+            .render("conf", &json!({ "options": options }))


Just a suggestion: I've used strict mode in the agent to ensure we fail early, in case a necessary variable is undefined

soenkeliebau · 2020-12-03T15:49:33Z

+    })
+}
+
+fn build_pod(


Haven't looked too closely at this function as I assume this will change fundamentally and was more to get the demo of the ground.
What I looked at seems totally fine.

…tion of pods. This is WIP and relies on unreviewed changes to operator-rs

lfrancke · 2020-12-19T23:01:40Z

Closing in favor of a new branch

…ackabletech/operator-templating repo. Original commit message: Add actions to build Helm charts to the operators and retire os package building. (#7) * First version - mostly working * Replace operator version placeholder in Helm chart. * Fix ansible equality test with older jinja version and make Makefile a j2 template. * Reenable all repos * Bugfix: indentation and Makefile. * Update template/.github/workflows/publish_dev_artifacts.yml.j2 Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de> * Update repositories.yaml Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de> * Update template/.github/workflows/publish_dev_artifacts.yml.j2 Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de> * Update template/.github/workflows/publish_dev_artifacts.yml.j2 Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com> * Update template/.github/workflows/publish_release_artifacts.yml.j2 Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com> * Update template/.github/workflows/publish_release_artifacts.yml.j2 Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com> * Moved crd.yaml to crds directory. * Update template/deploy/helm/[[product]]-operator/README.md.j2 Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com> * Update template/deploy/helm/[[product]]-operator/templates/serviceaccount.yaml.j2 Co-authored-by: Siegfried Weber <mail@siegfriedweber.net> * Removed kind action from Makefile. Added chart linting config back in. * Text fix * Addressed review comments * Added note to Readme about potentielly missing details. * Fix yp call and indentation in Makefile.j2 * Install roles.yaml when compiling the Helm chart * Added wildcard cluster role for all operators. * WIP: testing hive and druid. * WIP: testing with Trino fails. * Make roles.yaml a Jinja template. * More templating of the roles.yaml.j2 * Add update verb to configmaps resource. Co-authored-by: Razvan-Daniel Mihai <84674+razvan@users.noreply.github.com> Co-authored-by: Teo Klestrup Röijezon <teo.roijezon@stackable.de> Co-authored-by: Siegfried Weber <mail@siegfriedweber.net>

lfrancke added 22 commits November 13, 2020 14:20

Initial commit.

5cf3136

Based on https://github.com/clux/controller-rs This does not handle deletions yet.

Adds a simple way to handle Finalizers.

58ad4e6

Needs cleaning up.

Refactor & document

595f192

Simple pod creation.

d23a107

The operator now creates a single pod object per ZooKeeperCluster and also watches these pods for changes.

Multiple pods are being created.

7619bb4

Refactor into multiple packages and make internals a bit cleaner.

6858d0b

Adds ConfigMaps with all servers & proper command

c759a9c

Also watch our pods and fix location of config directory.

f6504d3

Add default ports to server list

3642733

Fix ports, the last commit was badly wrong.

f8f8b82

Adds missing configuration options required for a start.

f286056

myid file is still missing.

Also tries to support the myid file.

18a12a6

Version number will now be added to the image properly.

144a21d

Used to be v3_5_8 but is now 3.5.8 as intended.

Use our patch_resource method for ConfigMaps as well.

55d7dfd

myid file is now being written to the data directory.

2de6011

That's where it belongs!

Fixes wrong names for ConfigMap & data directory.

532295b

I need to pull out the configuration options into a common object.

Fix documentation

69b69d0

Don't include patch number in dependencies

b3b50d9

Forcefully assign pod to node.

fddc116

This is a temporary workaround, the goal is to use nodeSelectors and let the Scheduler assign pods.

Only support 3.4.14 for now.

90cc8da

The start script for 3.4 works differently than later versions and cl…

f2b426c

…ientPort was missing.

Adds zoo.cfg to config path

d6840d0

lfrancke linked an issue Nov 26, 2020 that may be closed by this pull request

Scaffold Operator Framework #1

Closed

lfrancke removed a link to an issue Nov 26, 2020

Scaffold Operator Framework #1

Closed

lfrancke linked an issue Nov 26, 2020 that may be closed by this pull request

Create Zookeeper CRD (Custom Resource Definition) #2

Closed

lfrancke requested review from soenkeliebau and removed request for soenkeliebau November 26, 2020 11:39

lfrancke marked this pull request as draft November 26, 2020 11:43

Refactor to use stackable-operator library

5e74f69

lfrancke requested a review from soenkeliebau November 29, 2020 22:38

lfrancke self-assigned this Nov 29, 2020

soenkeliebau reviewed Dec 3, 2020

View reviewed changes

Rework Operator, beginning of support for restarts & upgrades by dele…

730ef8d

…tion of pods. This is WIP and relies on unreviewed changes to operator-rs

lfrancke closed this Dec 19, 2020

soenkeliebau mentioned this pull request Nov 24, 2021

Update templated files to rev 2ce5e08 #274

Closed

Navigation Menu

Repository navigation

Basic implementation of ZooKeeper Operator - #7

Basic implementation of ZooKeeper Operator#7
lfrancke wants to merge 24 commits into
stackabletech:mainfrom
lfrancke:start

lfrancke commented Nov 23, 2020 •

edited

Loading

Uh oh!

soenkeliebau left a comment

Uh oh!

soenkeliebau Dec 3, 2020

Uh oh!

soenkeliebau Dec 3, 2020

Uh oh!

soenkeliebau Dec 3, 2020

Uh oh!

soenkeliebau Dec 3, 2020

Uh oh!

soenkeliebau Dec 3, 2020

Uh oh!

soenkeliebau Dec 3, 2020

Uh oh!

soenkeliebau Dec 3, 2020

Uh oh!

soenkeliebau Dec 3, 2020

Uh oh!

soenkeliebau Dec 3, 2020

Uh oh!

lfrancke commented Dec 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

lfrancke commented Nov 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

soenkeliebau left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lfrancke commented Dec 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lfrancke commented Nov 23, 2020 •

edited

Loading