Repository navigation
Nix pre-commit and ci checks #298
Description
Currently, the nix lock files (for crate2nix and for the packages via niv) are only updated when one of the Nix users runs:
make regenerate-nix, andniv update
This means that dependencies in Cargo.lock and Cargo.nix might be at different versions.
To resolve this, we can:
- Add the update commands to the pre-commit hooks, and/or
- Run the commands in CI and check for changes
Optionally, perhaps make regenerate-nix could also do the niv update so there is one command.
Metadata
Metadata
Assignees
Labels
No labels
Activity
nightkr commentedon Jun 10, 2024
make regenerate-nixandniv updateare fundamentally different commands.make regenerate-nixconverts the existing Cargo/etc lockfiles into Nix. It's idempotent, and exists to bring them back into sync. It will not update anything by itself. This is fine to do automatically.niv updateis likecargo update, it brings in whatever the latest version is of each (Niv) dependency. It should only be done with explicit user permission.NickLarsenNZ commentedon Jun 11, 2024
Yeah I understand that, but want to find a way to lower the burden on the developers.
We currently sometimes do
cargo update, but much less frequently do we runniv update. Not necessarily a bad thing if the currently pinned niv packages work, but if we update more frequently we would likely pull in security updates (or, y'know, zero-days 🙃).I think at minimum, I'd like to have CI (and pre-commit hooks) check that Cargo.nix is in line with Cargo.lock. We can work out the
niv updateprocess separately (I agree it should be intentional, but just done a bit more regularly).What do you think?