Repository navigation
Conversation
2 tasks
razvan
marked this pull request as ready for review
April 28, 2022 12:19
maltesander
requested changes
Apr 28, 2022
maltesander
left a comment
maltesander
left a comment
Member
There was a problem hiding this comment.
I would add a reference for namespace. Otherwise LGTM.
Co-authored-by: Malte Sander <malte.sander.it@gmail.com>
Member
Author
|
bors merge |
bors Bot
pushed a commit
that referenced
this pull request
Apr 28, 2022
## Description Fixes #377 Implement ADR structs from https://github.com/stackabletech/documentation/diffs/7?base_sha=9b576a1644961596cab2c812334adf164a5a1cd1&branch=adr%2Fs3&commentable=true&name=adr%2Fs3&pull_number=177&sha1=9b576a1644961596cab2c812334adf164a5a1cd1&sha2=b7cf18584869d1f64aac4c7d0be376ce07ed72c7&short_path=7e3be7c&unchanged=expanded&w=false#option5
Contributor
|
Pull request successfully merged into main. Build succeeded: |
bors
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #377
Implement ADR structs from https://github.com/stackabletech/documentation/diffs/7?base_sha=9b576a1644961596cab2c812334adf164a5a1cd1&branch=adr%2Fs3&commentable=true&name=adr%2Fs3&pull_number=177&sha1=9b576a1644961596cab2c812334adf164a5a1cd1&sha2=b7cf18584869d1f64aac4c7d0be376ce07ed72c7&short_path=7e3be7c&unchanged=expanded&w=false#option5
Review Checklist
Once the review is done, comment
bors r+(orbors merge) to merge. Further information