Repository navigation
fix(mcp): verify charger bindings through diagnostic reads - #41
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 19, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic redacted settings cannot establish a charger's exact driver binding. Technical troubleshooting now directs assistants through the full diagnostic catalogue and reads, compares the saved and configured names, and states the limits of the public profile.
A diagnostic HTTP refusal now returns MCP
isError: truewith the box's status and evidence. This prevents a rejected read from looking like a successful result. The existing grants still control access.Paired Core change: srcfl/ftw#1743 (saved-connection warnings and exact binding evidence). The instructions also support older boxes through their existing diagnostic reads.
Validation:
go vet ./...,go test -race ./...,go test -tags ftwclouddev ./...andbash scripts/check-imports.shpassed. OAuth/Noise tests preserve the old charger binding for comparison, flag a refused read, and retain the public profile's tool limits.Production Go growth: 10 net lines.