Repository navigation
Share buffered AWC transport for OIDC and telemetry - #1536
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OIDC discovery/token requests and OTLP exports each implement the same buffered AWC send and response-body lifecycle. Share that transport in the HTTP client module while keeping protocol-specific request conversion, response-header validation, logging, and error context in the adapters.
The helper validates response headers before reading the body and keeps send, header, and body failures distinct. OIDC retains its body timeout and text-only request headers; telemetry retains raw request-header support, existing timeout behavior, and its dedicated worker thread.
One parameterized suite exercises both adapters through a shared raw-response fixture: methods, request and response bodies, status codes, duplicate response headers, malformed headers, connection failures, invalid chunked payloads, and body timeouts. Raw responses cover malformed wire data that the existing echo/provider servers normalize. The existing hanging-body OIDC integration test verifies its configured timeout.
Consolidating the original adapter test modules retains all 16 request scenarios and their assertions while reducing the PR from 354 additions / 39 deletions to 279 additions / 41 deletions.
Validation:
cargo fmt --all -- --check,cargo clippy --all-targets --all-features -- -D warnings, andcargo test.