Repository navigation
Centralize Markdown rendering policy - #1532
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
lovasoa
enabled auto-merge
October 7, 2026 09:49
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use one private GFM options builder for the Markdown rendering function and Handlebars helper. Both paths retain the configured HTML/protocol policy and image handling, and the helper applies its existing allow_unsafe override afterward.
Regression coverage extends the existing Markdown test module and reuses its argument helpers. The compact matrix covers all four configuration combinations, raw HTML, dangerous links, data images, GFM, unsafe overrides, and unknown presets. Existing HTML/preset validation and default-policy tests remain intact; there is no parallel argument helper.
Validation: cargo fmt --all, cargo clippy --all-targets --all-features -- -D warnings, and cargo test --lib (236 tests passed).