Skip to content
This repository was archived by the owner on Apr 20, 2026. It is now read-only.

Close response bodies after successfully setting statuses #69

Closed
thna123459 wants to merge 1 commit into from
Closed

Close response bodies after successfully setting statuses #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/main/java/com/spotify/github/v3/clients/RepositoryClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,7 +221,11 @@ public CompletableFuture<Void> setCommitStatus(
final String path = String.format(STATUS_URI_TEMPLATE, owner, repo, sha);
return github
.post(path, github.json().toJsonUnchecked(request))
.thenAccept(IGNORE_RESPONSE_CONSUMER);
.thenAccept(response -> {
if (response.body() != null) {
response.body().close();
}
});
Comment on lines +224 to +228

@bguedel bguedel Aug 11, 2021

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about chaging IGNORE_RESPONSE_CONSUMER from (ignore) -> {} to what you have?

@thna123459 thna123459 Aug 11, 2021

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good idea, I was a little hesitant to make such a change because I only tested it with statuses, but let's be bold:
#70

}

/**
Expand Down