ArgumentError: invalid value for BigDecimal(): "N/A"

Steps to reproduce:

When attempting to produce an export when a test is present without enough participants to calculate the statistical confidence, exports raise an exception attempting to convert the string "N/A" to a float.

> csv_data = Split::Export.to_csv
ArgumentError: invalid value for BigDecimal(): "N/A"
from /Users/markb/.rbenv/versions/2.4.0/lib/ruby/gems/2.4.0/gems/split-export-2.0.0/lib/split/export.rb:10:in `initialize'

Could it convert the number to an integer instead of a string to give a value of 0.0?

[5] pry(main)> BigDecimal.new("NA".to_i).round(2).to_f
=> 0.0

@beet

@beet maybe we should just rescue and return the string instead?

@andrew

@andrew great idea.

I was going to create a fork, but rake spec fails with:

NameError:
  uninitialized constant RSpec::Expectations::MultipleExpectationsNotMetError
# ./spec/export_spec.rb:3:in `<top (required)>'

Tried upgrading rspec to 3.x, but can't get the tests to run.

I'm also seeing this exception for tests that have reached statistical significance. Can a patch be released to fix this bug?

splitrb#13 Rescue from ArgumentError when passing string into BigDeci…

Merge pull request #18 from Paprikas/fix-argument-error-issue-13

Fixed in #18

Navigation Menu

Repository navigation

ArgumentError: invalid value for BigDecimal(): "N/A" #13

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

ArgumentError: invalid value for BigDecimal(): "N/A" #13

Description

Activity

andrew commented on Oct 3, 2017

beet commented on Oct 3, 2017

nhippenmeyer commented on Nov 17, 2017

andrew commented on Jul 19, 2018

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions