Run the Chromium build check against the image's browsers - #93
Merged
splitbrain merged 1 commit intoOct 4, 2026
Merged
Conversation
Commit 8386f98 set the runtime PLAYWRIGHT_BROWSERS_PATH before the checks. The Chromium check then looked for its browser in the home, where only the entrypoint links the image's builds, and the box image build failed. The check now uses the image's browser directory, as it did before that commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the box image build on
main, which failed in 37196603548 after #92.Cause
#92 moved
ENV PLAYWRIGHT_BROWSERS_PATH=/home/agent/.cache/ms-playwrightto before the checks. The Chromium check (playwright-cli open) used to run while that variable still pointed at the image's browsers in/opt/playwright. Now it looked in the home:At runtime the entrypoint links the image's builds into that path. During the build, nothing does.
Fix
The Chromium check sets
PLAYWRIGHT_BROWSERS_PATHto$BOXES_IMAGE_BROWSERSfor its own step, which is the value it ran with before #92.The other checks depend on the moved variable as intended. The Firefox and WebKit check downloads into the home path. The symlink check sets its own path.
Testing
I cannot run containers on my machine, so this build is the first test of the fix.